libMagickWand.so.1.0.0 calling exit()

Questions and postings pertaining to the development of ImageMagick, feature enhancements, and ImageMagick internals. ImageMagick source code and algorithms are discussed here. Usage questions which are too arcane for the normal user list should also be posted here.
Post Reply
naoliv
Posts: 110
Joined: 2007-12-10T18:54:27-07:00
Location: Brazil

libMagickWand.so.1.0.0 calling exit()

Post by naoliv »

Hi!

While running a Debian package checker, I saw this:

Code: Select all

X: libmagickwand1: shlib-calls-exit usr/lib/libMagickWand.so.1.0.0
N: 
N:    The listed shared library calls the C library exit() or _exit()
N:    functions.
N:    
N:    In the case of an error, the library should instead return an
N:    appropriate error code to the calling program which can then determine
N:    how to handle the error, including performing any required clean-up.
N:    
N:    In most cases, removing the call should be discussed with upstream,
N:    particularly as it may produce an ABI change.
The same message is given for:

usr/lib/ImageMagick-6.4.8/modules-Q16/coders/jpeg.so
usr/lib/ImageMagick-6.4.8/modules-Q16/coders/msl.so
usr/lib/ImageMagick-6.4.8/modules-Q16/coders/png.so
usr/lib/ImageMagick-6.4.8/modules-Q16/coders/svg.so

Is it valid? If yes, do you plan to fix this?

Thank you!
User avatar
magick
Site Admin
Posts: 11064
Joined: 2003-05-31T11:32:55-07:00

Re: libMagickWand.so.1.0.0 calling exit()

Post by magick »

The exit() calls are not problematic. They, for example, are only used in methods used exclusively by the ImageMagick command line utilities (i.e. ImportUsage()). However, its certainly simple enough to remove them. We'll have patch for the problem by sometime tomorrow.

And thanks for the problem / bug reports. The entire ImageMagick user community benefits from your efforts.
Post Reply