Page 1 of 1

1 of 700 tests failed on FreeBSD 6.3 i386

Posted: 2008-12-11T03:57:14-07:00
by mvalery
OS: FreeBSD 6.3-RELEASE i386
cmd: # portupgrade ImageMagick-nox11-6.4.5.5
output:

Code: Select all

. . .
PASS: utilities/tests/charcoal.sh
PASS: utilities/tests/composite.sh
Image sized from 640x480 to 400x300.
PASS: utilities/tests/conjure.sh
PASS: utilities/tests/contrast.sh
. . .
===========================================
1 of 700 tests failed
Please report to http://www.imagemagick.org
===========================================
I'll glad to provide any additional information.

Re: 1 of 700 tests failed on FreeBSD 6.3 i386

Posted: 2008-12-11T06:57:47-07:00
by mvalery
PASS: tests/constitute_double_cmyk.sh
/usr/ports/graphics/ImageMagick/work/ImageMagick-6.4.7-5/tests/.libs/constitute -storagetype double /usr/ports/graphics/ImageMagick/work/ImageMagick-6.4.7-5/tests/input_truecolor.miff cmy
Constitute check failed: 6615/0.0587497/0.843137
FAIL: tests/constitute_double_cmy.sh

/usr/ports/graphics/ImageMagick/work/ImageMagick-6.4.7-5/tests/.libs/constitute -storagetype double /usr/ports/graphics/ImageMagick/work/ImageMagick-6.4.7-5/tests/input_truecolor.miff i
PASS: tests/constitute_double_i.sh
/usr/ports/graphics/ImageMagick/work/ImageMagick-6.4.7-5/tests/.libs/constitute -storagetype double /usr/ports/graphics/ImageMagick/work/ImageMagick-6.4.7-5/tests/input_truecolor.miff prgb
PASS: tests/constitute_double_prgb.sh

I think it's critical error. The update was stopped with error message.
It's successful updated on FreeBSD 7.0-RELEASE-p2 amd64 (one of my another servers)

Re: 1 of 700 tests failed on FreeBSD 6.3 i386

Posted: 2008-12-11T21:38:34-07:00
by magick
This is perplexing since all the regression tests pass on the hosts we have access to, Fedora, Centos, Mac OS X, Windows, and Solaris. Its curious that the test that fails uses doubles. There can be some fuzziness because of precision round-off but CMY is a one-to-one mapping to and from RGB so precision should not be an issue.

We used to test ImageMagick under FreeBSD on the HP TestDrive systems but they have discontinued this program. Can you provide a system we can use to investigate this problem report?

Re: 1 of 700 tests failed on FreeBSD 6.3 i386

Posted: 2008-12-12T13:43:42-07:00
by mvalery
magick wrote: We used to test ImageMagick under FreeBSD on the HP TestDrive systems but they have discontinued this program. Can you provide a system we can use to investigate this problem report?
Unfortunately I cannot. The system is leased to customer.
I'll address to FreeBSD maintainer of ImageMagick.
Probably I've encountered with known OS-dependent problem.

Re: 1 of 700 tests failed on FreeBSD 6.3 i386

Posted: 2008-12-13T12:17:41-07:00
by magick
We found a FreeBSD 7.0 system and built the latest ImageMagick release 6.4.7-7. All the regression tests passed as expected.

Re: 1 of 700 tests failed on FreeBSD 6.3 i386

Posted: 2008-12-13T17:29:39-07:00
by mvalery
magick wrote:We found a FreeBSD 7.0 system and built the latest ImageMagick release 6.4.7-7. All the regression tests passed as expected.
So am I. I've reported (see my previous post).

Seems, the problem appears on FreeBSD 6.3 only.
Now, I've encountered with same problem on another server on FreeBSD 6.3-RELEASE-p5 i386, installed two week ago. Error message is:
Constitute check failed: 6615/0.0587497/0.843137
FAIL: tests/constitute_double_cmy.sh

Re: 1 of 700 tests failed on FreeBSD 6.3 i386

Posted: 2008-12-13T18:05:06-07:00
by magick
Perhaps there is a bug in the compiler under FreeBSD 6.3. Hopefully we will be able to get access to a FreeBSD 6.3 system in the near future to resolve this problem. Thanks.

Re: 1 of 700 tests failed on FreeBSD 6.3 i386

Posted: 2008-12-21T15:11:24-07:00
by magick
Thanks to knigma we have a fix to this problem. The problem was within the regression test itself (i.e. tests/constitute.c) rather than in the ImageMagick API.

Re: 1 of 700 tests failed on FreeBSD 6.3 i386

Posted: 2008-12-27T13:03:30-07:00
by magick
Here is the patch:

Code: Select all

*** 284,289 ****
--- 284,290 ----
    (void) LogMagickEvent(CoderEvent,GetMagickModule(),
                          "Reading image from pixel array");
    final = AcquireImage((ImageInfo *) NULL);
+   final->colorspace=original->colorspace;
    SetImageExtent(final,columns,rows);
    (void) SetImageBackgroundColor(final);
    status = ImportImagePixels(final,0,0,columns,rows,map,storage_type,pixels);